Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLT-1628] Fix coredns, cluster-api-gcp and kube-rbac-proxy image registry and repository references #675

Open
wants to merge 7 commits into
base: branch-0.17.0-0.6
Choose a base branch
from
Open

[PLT-1628] Fix coredns, cluster-api-gcp and kube-rbac-proxy image registry and repository references #675

wants to merge 7 commits into from

Conversation

unai-ttxu
Copy link
Member

Description

Please add the PR description here.

Related Pull Requests

  • PR number: brief description (e.g. "documentation")
  • PR number: brief description (e.g. "tests enhancements")

Pull Request Checklist:

  • [PR title] Include a title referencing a ticket in Jira (e.g. "[CLOUDS-99] Implement a new funcionality").
  • [PR desc] Add a summary of the changes made in simple terms.
  • [PR desc] List any pull-request related to this change (docs, tests, feature, etc.).
  • [PR labels] Add the corresponding labels (release, skips, cherry-pick, AT-eks-smoke, etc).
  • [Docs] Are changes to the documentation required? (if so, please add references to those PRs).
  • [QA] Are new unit tests required according with the changes? (if so, please add references to those PRs).

@unai-ttxu unai-ttxu added bugfix Something isn't working ok-to-review 0.6.2 labels Feb 4, 2025
iamjanr
iamjanr approved these changes Feb 5, 2025
View reviewed changes
Copy link

@iamjanr iamjanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unai-ttxu unai-ttxu changed the title [PLT-1628] Fix coredns image registry and repository references [PLT-1628] Fix coredns and cluster-api-gcp image registry and repository references Feb 6, 2025
@unai-ttxu unai-ttxu changed the title [PLT-1628] Fix coredns and cluster-api-gcp image registry and repository references [PLT-1628] Fix coredns, cluster-api-gcp and kube-rbac-proxy image registry and repository references Feb 6, 2025
tperez-stratio
tperez-stratio approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@tperez-stratio tperez-stratio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tperez-stratio tperez-stratio tperez-stratio approved these changes

@iamjanr iamjanr iamjanr approved these changes

@lreciomelero lreciomelero Awaiting requested review from lreciomelero lreciomelero is a code owner

Assignees
No one assigned
Labels
0.6.2 bugfix Something isn't working ok-to-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unai-ttxu @tperez-stratio @iamjanr