Added STORAGE (thumbor_cloud_storage.storages.cloud_storage) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…different from STORAGE_CLOUD_STORAGE_ROOT_PATH to prevent conflicts
| @@ -74,7 +74,7 @@ def get(self): | |||
| return blob.download_as_string() | |||
|
|
|||
| def normalize_path(self, path): | |||
| path_segments = [self.context.config.get('RESULT_STORAGE_CLOUD_STORAGE_ROOT_PATH','thumbor/').rstrip('/'), Storage.PATH_FORMAT_VERSION, ] | |||
| path_segments = [self.context.config.get('RESULT_STORAGE_CLOUD_STORAGE_ROOT_PATH','thumbor/result_storage').rstrip('/'), Storage.PATH_FORMAT_VERSION, ] | |||
There was a problem hiding this comment.
This will be a backwards incompatible change, won't it? Which could incur a bunch of cache misses and costs to those upgrading.
I think it'd be better to recommend this and leave the result storage where it is, and then move the other storage into a subdirectory or different root directory, e.g. thumbor-strorage, with a recommendation to move them into better named directories or sub-directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for thumbor's STORAGE option. This saves the original image to the bucket. So that paths do not conflict, I set the default value of STORAGE_CLOUD_STORAGE_ROOT_PATH to thumbor/storage and changed the default of RESULT_STORAGE_CLOUD_STORAGE_ROOT_PATH to thumbor/result_storage