Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing glove #46

Merged
merged 7 commits into from
Feb 16, 2024
Merged

implementing glove #46

merged 7 commits into from
Feb 16, 2024

Conversation

Jean-Baptiste-Camps
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (dbe264b) 55.23% compared to head (e89c602) 54.23%.

Files Patch % Lines
superstyl/preproc/tuyau.py 11.76% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   55.23%   54.23%   -1.00%     
==========================================
  Files           3        3              
  Lines         172      177       +5     
==========================================
+ Hits           95       96       +1     
- Misses         77       81       +4     
Flag Coverage Δ
unittests 54.23% <11.76%> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jean-Baptiste-Camps
Copy link
Member Author

Ok, it might work, but it is WAY too slow. I'll look into `gensim'.

@Jean-Baptiste-Camps Jean-Baptiste-Camps mentioned this pull request Feb 16, 2024
@Jean-Baptiste-Camps Jean-Baptiste-Camps mentioned this pull request Feb 16, 2024
@Jean-Baptiste-Camps Jean-Baptiste-Camps merged commit 296fc21 into master Feb 16, 2024
3 of 6 checks passed
@Jean-Baptiste-Camps Jean-Baptiste-Camps deleted the glove branch February 16, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant