Hyperstyl a.1 #49
Merged
Hyperstyl a.1 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing coefficients to .csv file and displaying a message warning the user ot it.
Comments on the function name and description.
Correcting typo and completing bibliographic reference.
Including POS in English. May have to upgrade to Spacy POS-tagger, but will work in English for now.
I am tired: I rounded up what is already an integer... Now corrected to a lenght, not a rounded up value (which would be the same, but looks stupid)
Minor correction
Minor: indentation problem solved on l.97
Jean-Baptiste-Camps
requested changes
Feb 17, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
==========================================
- Coverage 90.83% 88.25% -2.58%
==========================================
Files 3 3
Lines 240 247 +7
==========================================
Hits 218 218
- Misses 22 29 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Validating the values of dimension reduction and sampling.
Jean-Baptiste-Camps
approved these changes
Feb 20, 2024
|
I really (really!) like that you have added test for valid options in some cases. We should generalise that ! |
Jean-Baptiste-Camps
merged commit 82858cd
into
SupervisedStylometry:master
4 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully no more errors, and still: