Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo on cmake command. Added note about building for Apple Silicon #349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deanwampler
Copy link

The cmake command needs ../.., not ...

I added a note about the cmake command for Apple Silicon.

@Syllo
Copy link
Owner

Syllo commented Dec 30, 2024

Not sure if I follow:

# This clones into the nvtop directory (by git's default cloning in a directory with the repo's name)
git clone https://github.com/Syllo/nvtop.git
# Create a build directory in nvtop and switch to it
mkdir -p nvtop/build && cd nvtop/build

So at that point, the directory should look something like:

ntop
├── CMakeLists.txt
└── build <- we are here

Hence, I don't see the point of the second parent directory to the cmake command since CMakeList.txt is in the direct parent.

I could perhaps update the documentation with more recent cmake commands like cmake -B nvtop/build -S nvtop && cmake --build nvtop/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants