Cleanup and modernize patcher #153
Annotations
10 errors and 5 notices
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/model/instrument/kit.cpp#L828
do not use C-style cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-cstyle-cast,-warnings-as-errors]
|
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/model/voice/voice.cpp#L85
constructor does not initialize these fields: assignedToSound, paramFinalValues, sourceValues, localExpressionSourceValuesBeforeSmoothing, inputCharacteristics, noteCodeAfterArpeggiation, portaEnvelopePos, portaEnvelopeMaxAmplitude, lastSaturationTanHWorkingValue, overallOscAmplitudeLastTime, sourceAmplitudesLastTime, modulatorAmplitudeLastTime, sourceWaveIndexesLastTime, filterGainLastTime, doneFirstRender, previouslyIgnoredNoteOff, orderSounded, overrideAmplitudeEnvelopeReleaseRate, nextUnassigned [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
|
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/model/voice/voice.cpp#L528
2147483648 is a magic number; consider replacing it with a named constant [readability-magic-numbers,-warnings-as-errors]
|
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/modulation/patch/patch_cable.h#L39
32 is a magic number; consider replacing it with a named constant [readability-magic-numbers,-warnings-as-errors]
|
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/modulation/patch/patch_cable.h#L39
5 is a magic number; consider replacing it with a named constant [readability-magic-numbers,-warnings-as-errors]
|
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/modulation/patch/patcher.cpp#L30
parameter name 'p' is too short, expected at least 3 characters [readability-identifier-length,-warnings-as-errors]
|
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/modulation/patch/patcher.cpp#L78
0xFFFFFF00 is a magic number; consider replacing it with a named constant [readability-magic-numbers,-warnings-as-errors]
|
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/modulation/patch/patcher.cpp#L78
do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]
|
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/modulation/patch/patcher.cpp#L84
536870912 is a magic number; consider replacing it with a named constant [readability-magic-numbers,-warnings-as-errors]
|
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/modulation/patch/patcher.cpp#L91
0xFFFFFF00 is a magic number; consider replacing it with a named constant [readability-magic-numbers,-warnings-as-errors]
|
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/model/voice/voice.cpp#L527
+3, including nesting penalty of 2, nesting level increased to 3
|
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/modulation/patch/patcher.h#L49
the first parameter in the range is 'source_values'
|
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/modulation/patch/patcher.h#L49
the last parameter in the range is 'param_final_values'
|
|
Run stellar-aria/clang-tidy-annotations@7a07996fe01ffaa846b0f4a5e9de3c58a3217f73:
src/deluge/modulation/patch/patcher.h#L52
differing parameters are named here: ('sources_changed'), in definition: ('sourcesChanged')
|
Loading