Skip to content

Commit

Permalink
Revert "Remoove deadBEEF"
Browse files Browse the repository at this point in the history
This reverts commit 5879265.
  • Loading branch information
stellar-aria committed Feb 12, 2025
1 parent e4ce3c8 commit c44c3d4
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions src/deluge/processing/sound/sound.h
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,23 @@ class Sound : public ModControllableAudio {
LFO globalLFO3;
LFOConfig lfoConfig[LFO_COUNT];

// December 3, 2024
// @todo
// Commit 6534979986d465a0acf01018e066e1d7ca1d170e
// From PR #2004 (LFO: cleanups in preparation for LFO2 sync support)
// (https://github.com/SynthstromAudible/DelugeFirmware/pull/2004)
// Removed four uint8_t lfo variables from this section and replaced them with the LFOConfig
// definition above. This unknowingly introduced a "release" bug which changed the sound of the
// Deluge synth engine compared to 1.1 as reported in issue #2660:
// (https://github.com/SynthstromAudible/DelugeFirmware/issues/2660)
// As a TEMPORARY solution, padding is being added here to fix the bug so as to not hold up
// the 1.2 Beta release.
// Emphasis on temporary as this bug needs a proper fix, otherwise it will keep coming back
// as changes get made to this Sound class.
// We think the issue relates to the use of "offsetof" in the param and patcher system
// (related to the paramFinalValues / globalSourceValues definitions above)
uint32_t temporaryPadding{0xDEADBEEF};

ModKnob modKnobs[kNumModButtons][kNumPhysicalModKnobs];

int32_t sideChainSendLevel;
Expand Down

0 comments on commit c44c3d4

Please sign in to comment.