-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature / New "Reverse" probability (for sequenced and arpeggiated notes) #3314
Feature / New "Reverse" probability (for sequenced and arpeggiated notes) #3314
Conversation
…synth and kit affect-entire
# Conflicts: # src/deluge/gui/views/audio_clip_view.cpp
Found the crash and fixed it. This is ready for review! |
The person that reviews this: please take special attention to the places where i have replaced "reversed" with isReversed() AND the places where i have not replaced it. I think i made the right choices but maybe some more experimented dev can find something else |
# Conflicts: # src/deluge/processing/sound/sound.cpp
# Conflicts: # src/deluge/gui/views/automation_view.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy has made some suggestions. Please note that they are machine-generated, and you should review them carefully before applying to avoid introducing bugs.
There were too many comments to post at once. Showing the first 25 out of 73. Check the log or trigger a new build to see more.
Updated loopy pro template and docs. Ready for review |
@@ -29,5 +29,8 @@ class Octaves final : public Integer { | |||
bool isRelevant(ModControllableAudio* modControllable, int32_t whichThing) override { | |||
return !soundEditor.editingGateDrumRow(); | |||
} | |||
void getColumnLabel(StringBuf& label) override { | |||
label.append(deluge::l10n::getView(deluge::l10n::built_in::seven_segment, this->name).data()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't do this, string view data is an array of characters and not a null terminated string
More realistically you could refactor string buf append to take a string view pretty easily - it just needs the signature changed and then an update to use strncat with the view length instead of strcat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to implement that suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See review below, tldr just use l10n::get
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, overall logic seems sound, although I didn't do a deep-dive
Co-authored-by: Katherine Whitlock <[email protected]>
Co-authored-by: Katherine Whitlock <[email protected]>
a495e10
Reverse Probability (RVRS): It applies a chance of inverting the Reverse sample setting just for the current note to be played. This probability only affects the oscillators whose type is set to Sample. Note: you can find this parameter also at the root level of the sound menu, under Randomizer, because this parameter affects both sequenced notes and arpeggiated notes.
This PR also contains this: