Feature / Kit Arpeggiator #3388
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an arpeggiator menu to the Kit affect-entire menu. This allows the user to engage an arpeggiator layer on top of the kit rows, which will control which rows receive noteOns and noteOffs. That means that the kit rows can have their own arpeggiators also enabled, which allows for unlimited possible pattern combinations.
If kit rows have a sample with sampleMode = ONCE, they will be automatically ignored from kit arpeggiator. For them to be eligible to participate in kit arpeggiator, they new to allow to input note tails in the sequencer, that is, the row is a synth or is a sample with sampleMode = CUT or LOOP.
Every kit row now has an option "Include in kit arpeggiator" inside the Arpeggiator menu, to allow them to opt-out from kit arp.