This repository has been archived by the owner on Jun 30, 2024. It is now read-only.
Refactor moji changed #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
14d37b2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1f7d9f36.geekcamp-2022-vol3.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットURL
対応内容・対応背景・妥協点
やったこと
idの名称を命名規則に従い変更
要素名＿部品名＿アクティビティ名＿アクティビティの種類＿（String）
やってないこと
それ以外は何もやっていない
UI before / after
UIや振る舞いが変わる場合はbefore / afterのスクショや動画を共有する
テスト
テスト項目、テスト方法を書く
レビュー観点
あくまで目安です。
補足