Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint8 395 ideas tab #447

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Sprint8 395 ideas tab #447

merged 3 commits into from
Dec 9, 2024

Conversation

rmathew1011
Copy link

@rmathew1011 rmathew1011 commented Dec 9, 2024

Description

This PR removes the "Ideas" tab from the discovery templates.

Supporting Material

Additional Comments

DevOps team, please reprovision scholars database following this update to ensure the "Ideas" tab is not displayed.
Please include this step in the deployment process for PRE and PROD environments

Helper Checklist (optional)

Please ensure the following has been completed.

  • Changes are documented to the best of your understanding.
  • Changes are reviewed and accepted.

@Dbreck-TAMU Dbreck-TAMU changed the base branch from tamu-main to sprint8-staging December 9, 2024 16:49
@@ -152,7 +152,7 @@ spring:
# database-platform: org.hibernate.dialect.PostgreSQLDialect

generate-ddl: false
hibernate.ddl-auto: none
Copy link

@wwtamu wwtamu Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo this please. The database schema is created via Liquibase. The only instruction needed is to drop and recreate the database as defaults are what we require. The defaults are loaded from YAML on startup when configured to do so. There is also a backlog issue to test update defaults configuration which is technically all that should be required for the default change to apply.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change reverted

Copy link

@wwtamu wwtamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the ddl-auto property change.

Reverted changes in the `application yml file to 
`hibernate.ddl-auto: none`
@rmathew1011 rmathew1011 merged commit 92d8c53 into sprint8-staging Dec 9, 2024
@rmathew1011 rmathew1011 linked an issue Dec 18, 2024 that may be closed by this pull request
@Dbreck-TAMU Dbreck-TAMU deleted the sprint8-395-ideas-tab branch December 20, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Discovery view: Hide "Ideas" tab
3 participants