This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Add key sort #140
Merged
Add key sort #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
requested review from
KendallWeihe,
shamilovtim,
diehuxx and
frankhinek
as code owners
TBD Spec Test Vectors Report (tbdex-rs)
❌ Missing Vectors (1)These are test vectors without any test cases.
Automatically generated at: 2024-10-15T17:48:54.818Z |
TBD Spec Test Vectors Report (tbdex-core-kt)
Automatically generated at: 2024-10-15T17:52:30.995Z |
crates/tbdex/src/resources/mod.rs
Outdated
| impl ResourceKind { | ||
| pub fn typesafe_id(&self) -> Result<String> { | ||
| let dynamic_type = DynamicType::new(&self.to_string())?; | ||
| Ok(TypeSafeId::from_type_and_uuid(dynamic_type, Uuid::new_v4()).to_string()) | ||
| let timestamp_nanos = Utc::now().timestamp_nanos_opt().unwrap(); |
There was a problem hiding this comment.
Can we map the error into a TbdexError instead of risking a panic from the unwrap?
KendallWeihe
approved these changes
Oct 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.