Add KeyValueInt to CBaseEntity #60
Conversation
There was a problem hiding this comment.
Personally I have no issues with this as-is, but I'd like to note that in #30, @Kenzzer preferred these to be implemented as natives to reduce transitions between C++ and SP. Unless you'd be willing to do it now, the native implementation could be done on a separate PR while this can be taken in as a temporary substitute, but I want to see his opinion on this first.
|
I'm okay with taking this in as-is, those functions are meant to be called only on entity creation so it's okay we can always change the definition later (don't forget to product version bump), but yes I'd prefer a C++ implem just for performance. However for collisionchanged/etc (outside this PR's scope) my stance remains the same, if ever added as natives they must be C++. |
No description provided.