Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add bug fixes that never got committed to main #369

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

DESm1th
Copy link
Contributor

@DESm1th DESm1th commented Jan 17, 2025

This PR contains a variety of bug fixes that fell through the cracks as a result of my head injury at the end of 2023 (ugh).

  • [9279812] Pass the correct log level to dcm2bids
  • [4cde97a] XNAT series numbers sometimes end up with a string appended when a merge goes wrong and series numbers get duplicated (this is an error that must be addressed within XNAT when it occurs). This fix stops these malformed series numbers from crashing the entire run of dm_xnat_extract.py
  • [3fa8c3e] This fix stops a single exporter from crashing an entire run of dm_xnat_extract when an exception is raised.
  • [5634635, 7341296, c21ecee] Contain a bunch of exporter bug fixes for when dcm2bids is used as the primary export method. This code should be refactored later, but is safe to merge. It has been running in production for the last year (despite not being committed to github, sorry!)

@DESm1th DESm1th requested a review from a team as a code owner January 17, 2025 22:19
@github-actions github-actions bot added the fix Tagged PR fixes a bug label Jan 17, 2025
@DESm1th DESm1th merged commit b1cdb7b into TIGRLab:main Jan 17, 2025
4 of 6 checks passed
@DESm1th DESm1th deleted the missing_fixes branch January 17, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Tagged PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant