feat(jupyter): add hub bind url #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PACordonnier #197 is merged, you can resolve conflicts |
|
@PACordonnier Can you resolve conflicts please ? |
PACordonnier
force-pushed
the
196-specify-jupyter-hub-api-bind_url
branch
from
00b6c51 to
51b69ee
Compare
PACordonnier
force-pushed
the
196-specify-jupyter-hub-api-bind_url
branch
from
51b69ee to
39dcacd
Compare
|
Conflict resolved, sorry for delay. merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes #196
Additional comments
Will create a conflict with #197 once merged, with approval on both I will manage the merge
Agreements