Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace spongycastle with latest release version #1874

Closed
wants to merge 1 commit into from

Conversation

TranceLove
Copy link
Collaborator

Fixes #1870.

Steps to reproduce the required jars: (assume Ubuntu here)

  1. install openjdk-8-jdk, maven, ant, git
    2a. curl -sL https://deb.nodesource.com/setup_12.x | sudo -E bash -
    2b. sudo apt-get install -y nodejs
  2. install mybc: sudo npm install -g @jbuhacoff/mybc
  3. git clone https://github.com/bcgit/bc-java && cd bc-java
  4. git checkout r1v65 (as of Apr 2020, latest release version is 1.65)
  5. mybc prebuild --providerName SC --packageName org.spongycastle --displayName SpongyCastle
  6. bash ./build15+
  7. mybc postbuild --groupId com.madgag.spongycastle
  8. find the jars in $HOME/.m2/repository, copy bc{prix,prov}-jdk15on-{builtReleaseVersion}.jar to app/libs, replace any previous versions of the jars
  9. resync, rebuild as usual

Tested on Fairphone 3 running LineageOS 16 GSI establishing SSH connection to home server; also tested with Robolectric and Espresso tests that depends on crypto libraries (with the help of #1831).

Fixes TeamAmaze#1870.

Steps to reproduce the required jars: (assume Ubuntu here)

1. install openjdk-8-jdk, maven, ant, git
2a. curl -sL https://deb.nodesource.com/setup_12.x | sudo -E bash -
2b. sudo apt-get install -y nodejs
3. install mybc: sudo npm install -g @jbuhacoff/mybc
4. git clone https://github.com/bcgit/bc-java && cd bc-java
5. git checkout r1v65 (as of Apr 2020, latest release version is 1.65)
6. mybc prebuild --providerName SC --packageName org.spongycastle --displayName SpongyCastle
7. bash ./build15+
8. mybc postbuild --groupId com.madgag.spongycastle
9. find the jars in $HOME/.m2/repository, copy bc{prix,prov}-jdk15on-{latestReleaseVersion}.jar to app/libs, replace any previous versions of the jars
10. resync, rebuild as usual

Tested on Fairphone 3 running LineageOS 16 GSI establishing SSH connection to home server; also tested with Robolectric and Espresso tests that depends on crypto libraries (with the help of TeamAmaze#1831).
@TranceLove TranceLove added Issue-Task (low) This isn't a bug, but should be dealt with. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Apr 15, 2020
@TranceLove TranceLove closed this Apr 20, 2020
@TranceLove TranceLove deleted the bugfix/issue1870 branch April 20, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task (low) This isn't a bug, but should be dealt with.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For more security spongycastle -> bouncycastle
1 participant