Migrate to stock Bouncycastle #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes TeamAmaze#1870. Per - Remove stock Bouncycastle provider bundled with Android - Register updated Bouncycastle provider as first crypto provider available - Remove proguard config related to Spongycastle - Update code to obtain crypto provider directly without prefix
TranceLove
added
Issue-Task (low)
|
Working as expected. Approving. However, there's a miss in a use-case and the app crashes. I think it because of other PR we recently merged (using URI to handle file opening). I'm unable to test the encrypted file opening part because of the bug. |
VishalNehra
approved these changes
May 2, 2020
|
@TranceLove, @VishalNehra, @bowiechen: Thanks a lot! |
|
Oops, my bad. Will do a little PR to fix this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1870.
Per @Neustradamus suggested and rtyley/spongycastle#34 we should deprecate Spongycastle and use Bouncycastle directly without worrying about package name/class loading collisions.
Changes:
Related robolectric tests passed, Espresso tests were passed on Android emulators running 4.4, 6.0, 8.0, Oneplus 2 running AOSPExtended (7.1.2) and Fairphone 3 running LineageOS 16 GSI (9.0). Also tested on Fairphone 3 with production build (proguard enabled) on encrypting/decrypting files and establishing SSH connections.