asteroid dimension #320

maxryan008 · 2024-05-22T12:14:42Z

Fixed some textures plus added asteroid dimension

Added Asteroids Dimension and configured skybox. Haven't started terrain generation yet.

…e-fixes

Completed Asteroid Dimension Terrain Generation Structures/Features not implemented yet

Canned food items can now be created from any food with ease. planning to add automatic food detection that creates cans for any mods foods.

…e-fixes

canned food items have been almost completed other than fixing appleskins api integration and creating a machine to make cans in survival

canned food items completed - added total nutrition - fixed whitespace - added appleskin integration for canned food Todo - create canning machine to make canned food accessible in survival

food canner fully implemented and works completely. also put licencensing on all new files i have created

sort of started working on asteroid dimension structures

removed TODO: comment in food_canner json because it was causing issues. make sure in future to change the recipe for the food canner block ad the advancement requirements added licencing

fixed json issue added only eat canned food in space sealer code half implemented. uploading github because need backup because rewriting sealer AGAIN...

- added asteroid ores + dense ice - fixed some data generation issues - made asteroid dimension pitch black - fixed air lock seal for the second time - fixed canned food textures

- Fixed translations for canned food - Fixed ores aswell because asteroid ores where broken

Launch pads are now dynamic and are created using one method in the RocketParts class

added Rocket Nose Cone items

This reverts commit 697ed02.

This reverts commit 8087c7e.

This reverts commit 838e1cb.

decided to leave rocket code as is because rebuilding everything from scratch was painful. just going to build ontop of the already implemented system

…e-fixes

Updated everything to work with 1.21

TheMCSpacePro · 2024-11-26T22:51:51Z

Rockets?

…e-fixes

fixed most generated files and moved some to resources

Fixed most of the bugs with the oxygen sealer. Few more to fix but need to fetch the main branch first to fix conflicts

…e-fixes

Sealers are now at a stage where they are usable in the game. They arent perfect but they are usable

Roelymole

I have looked over most things, but there is a lot, so my comments are by no means exhaustive. Hopefully this should be enough for you to get started on making some changes. I do think there is a fair amount of redundancy which you could work on reducing, so maybe the next time someone looks there won't be nearly so much to review.

Roelymole · 2025-02-12T10:53:30Z

...main/generated/data/galacticraft/advancement/recipes/building_blocks/raw_aluminum_block.json

Did you use the raw aluminum block as a placeholder for the canner at some point? Either way I think you should revert these changes or rename the file.

Roelymole · 2025-02-12T11:01:43Z

src/main/java/dev/galacticraft/api/perlin/FishyNoise.java

Does all of this noise generation need to be ported? If the vanilla noise generation can be used then it would be better and I suspect that it is possible now.

Roelymole · 2025-02-12T11:09:21Z

src/main/java/dev/galacticraft/mod/GalacticraftClient.java

I feel like a lot of this code should be in a different class such as GCItems.

Roelymole · 2025-02-12T11:12:40Z

src/main/java/dev/galacticraft/mod/client/gui/screen/ingame/FoodCannerScreen.java

I don't really like the opening curly brackets being on the next line and it is not being done consistently or in the same style as the other screen classes.

Roelymole · 2025-02-12T11:19:46Z

src/main/java/dev/galacticraft/mod/client/gui/screen/ingame/OxygenSealerScreen.java

+            if (!status.equals(GCMachineStatuses.BLOCKED)) {
+                int sealCheckTime = this.menu.sealTickTime;
+                //TODO: make this a bar that goes down over time to match gc4's sealer screen?
+                graphics.drawString(this.font, Component.literal("Sealer Recheck: ").append(String.valueOf(sealCheckTime)), this.leftPos + 50, this.topPos + 50, ChatFormatting.YELLOW.getColor(), false);


Could you make this hardcoded text translatable. Also, I think it is best if you include the %s placeholder e.g. "Sealer Recheck: %s" so that the translations have more control over the formatting. Look at the machine status above for an example.

Roelymole · 2025-02-12T11:31:08Z

src/main/java/dev/galacticraft/mod/content/item/CannedFoodItem.java

+
+    public static void registerCan(ItemStack cannedFoodType)
+    {
+        ItemGroupEvents.modifyEntriesEvent(ResourceKey.create(Registries.CREATIVE_MODE_TAB, Constant.id(Constant.Item.ITEM_GROUP_CANS))).register(entries -> {


Would registering all of the canned food before the creative mode tabs remove the need for this?

Roelymole · 2025-02-12T11:37:39Z

src/main/java/dev/galacticraft/mod/data/GCTranslationProvider.java

@@ -399,6 +400,9 @@ protected void generateItemTranslations() {
        this.item(GCItems.AMBIENT_THERMAL_CONTROLLER, "Ambient Thermal Controller");

        // FOOD
+        this.item(GCItems.CANNED_FOOD, "Canned ");


Could you also use the %s placeholder here so that it is more translatable, as other languages might have a different word order.

Roelymole · 2025-02-12T11:38:20Z

src/main/java/dev/galacticraft/mod/data/GCTranslationProvider.java

@@ -911,6 +914,8 @@ protected void generateUiTranslations() {
        this.add(Ui.GIANT_LEAP, "Taking one giant leap");
        this.add(Ui.PREPARE_FOR_ENTRY, "Prepare for entry!");
        this.add(Ui.TRAVELING_TO, "Traveling to: %s");
+
+        this.add(Ui.TOTAL_NUTRITION, "Total Nutrition: ");


Another %s placeholder would be good.

Roelymole · 2025-02-12T11:39:44Z

src/main/java/dev/galacticraft/mod/events/GCEventHandlers.java

+                {
+                    return InteractionResultHolder.pass(itemStack);
+                } else {
+                    player.displayClientMessage(Component.literal("You cannot eat this here!").withColor(Color.RED.getRGB()), true);


Please make this hardcoded text translatable.

Roelymole · 2025-02-12T11:44:30Z

src/main/resources/assets/galacticraft/textures/gui/food_canner_screen.png

These slot sprites will need to be removed from this texture and added in a different way. The style of them will need to be updated too.

maxryan008 added 4 commits May 22, 2024 22:11

first commit

a6604e4

Added Asteroids Dimension

b7cfc2d

Added Asteroids Dimension and configured skybox. Haven't started terrain generation yet.

Merge remote-tracking branch 'upstream/main' into 1.20.4-block-textur…

b2b9c89

…e-fixes

Asteroid Dimension Terrain Generation

c25e0c6

Completed Asteroid Dimension Terrain Generation Structures/Features not implemented yet

maxryan008 changed the title ~~texture/model fixes~~ asteroid dimension May 28, 2024

maxryan008 added 8 commits May 29, 2024 10:00

Fixed File not exists when loading Asteroid Dimension

25ec673

Reworked canned food items

b2cc1c3

Canned food items can now be created from any food with ease. planning to add automatic food detection that creates cans for any mods foods.

Merge remote-tracking branch 'upstream/main' into 1.20.4-block-textur…

ffc8942

…e-fixes

Merge remote-tracking branch 'upstream/main' into 1.20.4-block-textur…

a980842

…e-fixes

canned food items

7010fda

canned food items have been almost completed other than fixing appleskins api integration and creating a machine to make cans in survival

canned food complete

af5ca3b

canned food items completed - added total nutrition - fixed whitespace - added appleskin integration for canned food Todo - create canning machine to make canned food accessible in survival

Fully finished food canner

55ad014

food canner fully implemented and works completely. also put licencensing on all new files i have created

started rudimentary work on structures

ac3acde

sort of started working on asteroid dimension structures

marcus8448 marked this pull request as draft July 31, 2024 18:08

maxryan008 added 15 commits August 19, 2024 19:39

fixed licenscing + more

1db30d3

removed TODO: comment in food_canner json because it was causing issues. make sure in future to change the recipe for the food canner block ad the advancement requirements added licencing

no summary???

76b6233

fixed json issue added only eat canned food in space sealer code half implemented. uploading github because need backup because rewriting sealer AGAIN...

working more on sealers

0115cd9

Fixed data generation and ran data generation

b116b82

minor tweaks

580ffb6

- added asteroid ores + dense ice - fixed some data generation issues - made asteroid dimension pitch black - fixed air lock seal for the second time - fixed canned food textures

Translation fixes

e4c20f3

- Fixed translations for canned food - Fixed ores aswell because asteroid ores where broken

Made launch pads dynamic

838e1cb

Launch pads are now dynamic and are created using one method in the RocketParts class

Rocket Nose Cone Part added

8087c7e

added Rocket Nose Cone items

made machines autogenerated

697ed02

Revert "made machines autogenerated"

a643484

This reverts commit 697ed02.

Revert "Rocket Nose Cone Part added"

d198e83

This reverts commit 8087c7e.

Revert "Made launch pads dynamic"

90f54b5

This reverts commit 838e1cb.

Reverted all rocket changes but left machine changes

2611ae7

decided to leave rocket code as is because rebuilding everything from scratch was painful. just going to build ontop of the already implemented system

Merge remote-tracking branch 'upstream/main' into 1.20.4-block-textur…

8d8cd83

…e-fixes

Merged into main 1.21 branch

8e8a2e2

Updated everything to work with 1.21

maxryan008 force-pushed the 1.20.4-block-texture-fixes branch from 4c5d2c2 to 8e8a2e2 Compare September 3, 2024 14:06

maxryan008 added 5 commits December 4, 2024 13:31

Merge remote-tracking branch 'upstream/main' into 1.20.4-block-textur…

fb40b39

…e-fixes

fixed generated files

69012f2

fixed most generated files and moved some to resources

Oxygen Sealer Implemented Better

f36c464

Fixed most of the bugs with the oxygen sealer. Few more to fix but need to fetch the main branch first to fix conflicts

Merge remote-tracking branch 'upstream/main' into 1.20.4-block-textur…

0e7aea1

…e-fixes

Finished Sealers Sort Of

a3be2ac

Sealers are now at a stage where they are usable in the game. They arent perfect but they are usable

maxryan008 marked this pull request as ready for review February 12, 2025 10:38

Roelymole requested changes Feb 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

asteroid dimension #320

asteroid dimension #320

maxryan008 commented May 22, 2024 •

edited

Loading

TheMCSpacePro commented Nov 26, 2024

Roelymole left a comment

Roelymole Feb 12, 2025

Roelymole Feb 12, 2025

Roelymole Feb 12, 2025

Roelymole Feb 12, 2025

Roelymole Feb 12, 2025

Roelymole Feb 12, 2025

Roelymole Feb 12, 2025

Roelymole Feb 12, 2025

Roelymole Feb 12, 2025

Roelymole Feb 12, 2025

asteroid dimension #320

Are you sure you want to change the base?

asteroid dimension #320

Conversation

maxryan008 commented May 22, 2024 • edited Loading

TheMCSpacePro commented Nov 26, 2024

Roelymole left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maxryan008 commented May 22, 2024 •

edited

Loading