Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: auto register BlockItem's and inline item registration #415

Merged
merged 3 commits into from
Feb 12, 2025
Merged

refactor: auto register BlockItem's and inline item registration #415

merged 3 commits into from
Feb 12, 2025

Conversation

JustAPotota
Copy link
Contributor

  • Replace registering BlockItems in GCItems with using BLOCKS.registerWithItem() in GCBlocks
  • For other types of items, they're now declared and registered in one go instead of separately
  • Remove Herobrine Air Lock Seal item

Roelymole
Roelymole reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@Roelymole Roelymole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better than the current system to me. May you resolve these few conflicts and then if nobody has any objections could we merge this soon?

@JustAPotota
Copy link
Contributor Author

Should be good to go now 👍

@Roelymole Roelymole merged commit 9aa2888 into TeamGalacticraft:main Feb 12, 2025
1 check passed
@JustAPotota JustAPotota deleted the chore/register-refactor-the-sequel branch February 12, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roelymole Roelymole Roelymole left review comments

@AlphaMode AlphaMode AlphaMode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustAPotota @AlphaMode @Roelymole