Skip to content

Commit

Permalink
ANDROID-14618 Checkbox links not underlined (#354)
Browse files Browse the repository at this point in the history
  • Loading branch information
pmartinbTEF authored May 20, 2024
1 parent f404f11 commit 5851d93
Show file tree
Hide file tree
Showing 115 changed files with 8 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import android.os.Bundle
import android.text.Spannable
import android.text.SpannableString
import android.text.Spanned
import android.text.TextPaint
import android.text.method.LinkMovementMethod
import android.text.style.ClickableSpan
import android.view.LayoutInflater
Expand All @@ -28,7 +29,7 @@ class InputsCatalogFragment : Fragment() {
override fun onCreateView(
inflater: LayoutInflater,
container: ViewGroup?,
savedInstanceState: Bundle?
savedInstanceState: Bundle?,
): View? {
super.onCreateView(inflater, container, savedInstanceState)
return layoutInflater.inflate(R.layout.screen_inputs_catalog, container, false).apply {
Expand Down Expand Up @@ -133,6 +134,11 @@ class InputsCatalogFragment : Fragment() {
override fun onClick(checkBox: View) {
checkBox.cancelPendingInputEvents()
}

override fun updateDrawState(ds: TextPaint) {
ds.color = ds.linkColor
ds.isUnderlineText = false
}
}

private val customTextInputValidation = object : TextInputValidation {
Expand Down
Binary file modified library/screenshots/CheckBoxInput_BlauBrand__checked.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified library/screenshots/CheckBoxInput_BlauBrand__checked_dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified library/screenshots/CheckBoxInput_BlauBrand__disabled_checked.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified library/screenshots/CheckBoxInput_BlauBrand__errorText_checked.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified library/screenshots/CheckBoxInput_BlauBrand__unchecked.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified library/screenshots/CheckBoxInput_BlauBrand__unchecked_dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified library/screenshots/CheckBoxInput_MovistarBrand__checked.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified library/screenshots/CheckBoxInput_MovistarBrand__checked_dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified library/screenshots/CheckBoxInput_MovistarBrand__unchecked.png
Binary file modified library/screenshots/CheckBoxInput_O2Brand__checked.png
Binary file modified library/screenshots/CheckBoxInput_O2Brand__checked_dark.png
Binary file modified library/screenshots/CheckBoxInput_O2Brand__disabled_checked.png
Binary file modified library/screenshots/CheckBoxInput_O2Brand__disabled_unchecked.png
Binary file modified library/screenshots/CheckBoxInput_O2Brand__errorText_checked.png
Binary file modified library/screenshots/CheckBoxInput_O2Brand__errorText_unchecked.png
Binary file modified library/screenshots/CheckBoxInput_O2Brand__unchecked.png
Binary file modified library/screenshots/CheckBoxInput_O2Brand__unchecked_dark.png
Binary file modified library/screenshots/CheckBoxInput_O2NewBrand__checked.png
Binary file modified library/screenshots/CheckBoxInput_O2NewBrand__checked_dark.png
Binary file modified library/screenshots/CheckBoxInput_O2NewBrand__disabled_checked.png
Binary file modified library/screenshots/CheckBoxInput_O2NewBrand__unchecked.png
Binary file modified library/screenshots/CheckBoxInput_O2NewBrand__unchecked_dark.png
Binary file modified library/screenshots/CheckBoxInput_TelefonicaBrand__checked.png
Binary file modified library/screenshots/CheckBoxInput_TelefonicaBrand__unchecked.png
Binary file modified library/screenshots/CheckBoxInput_TuBrand__checked.png
Binary file modified library/screenshots/CheckBoxInput_TuBrand__checked_dark.png
Binary file modified library/screenshots/CheckBoxInput_TuBrand__disabled_checked.png
Binary file modified library/screenshots/CheckBoxInput_TuBrand__disabled_unchecked.png
Binary file modified library/screenshots/CheckBoxInput_TuBrand__errorText_checked.png
Binary file modified library/screenshots/CheckBoxInput_TuBrand__errorText_unchecked.png
Binary file modified library/screenshots/CheckBoxInput_TuBrand__unchecked.png
Binary file modified library/screenshots/CheckBoxInput_TuBrand__unchecked_dark.png
Binary file modified library/screenshots/CheckBoxInput_VivoBrand__checked.png
Binary file modified library/screenshots/CheckBoxInput_VivoBrand__checked_dark.png
Binary file modified library/screenshots/CheckBoxInput_VivoBrand__disabled_checked.png
Binary file modified library/screenshots/CheckBoxInput_VivoBrand__errorText_checked.png
Binary file modified library/screenshots/CheckBoxInput_VivoBrand__unchecked.png
Binary file modified library/screenshots/CheckBoxInput_VivoBrand__unchecked_dark.png
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ private fun AnnotatedString.Builder.highlightText(
withStyle(
style = SpanStyle(
color = highlightColor,
textDecoration = TextDecoration.Underline,
textDecoration = TextDecoration.None,
),
) {
append(highlight)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ class CheckBoxInput @JvmOverloads constructor(
LayoutInflater.from(context).inflate(R.layout.input_checkbox, this, true)

checkBox = findViewById(R.id.checkbox_input)

setChecked(initialInputChecked)
setText(initialInputText)
configureErrorResetOnCheckChange()
Expand Down

0 comments on commit 5851d93

Please sign in to comment.