ANDROID-14490 expose content description in sheet actions (#339)

* ANDROID-14490 update bottom sheet actions to expose contentDescription * ANDROID-14490 add AccesibilityElementType
Telefonica · Apr 3, 2024 · d2661a8 · d2661a8
1 parent e0e1864
commit d2661a8
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 0 deletions.
diff --git a/library/src/main/java/com/telefonica/mistica/sheet/SheetModel.kt b/library/src/main/java/com/telefonica/mistica/sheet/SheetModel.kt
@@ -49,6 +49,7 @@ data class RowSelectable(
 data class RowAction(
     val id: String,
     val title: String,
+    val contentDescription: String? = null,
     val style: RowActionStyle = RowActionStyle.Default,
     @Deprecated("Use new field rowAsset. RowAsset will have preference over asset")
     val asset: Drawable? = null,

diff --git a/library/src/main/java/com/telefonica/mistica/sheet/children/list/ListElementViewData.kt b/library/src/main/java/com/telefonica/mistica/sheet/children/list/ListElementViewData.kt
@@ -30,6 +30,7 @@ internal sealed class ListElementViewData(
         override val id: String,
         val onClickListener: OnClickListener,
         val title: String,
+        val contentDescription: String,
         val rowActionStyle: RowActionStyleViewData = RowActionStyleViewData.Default,
         val asset: RowAssetViewData?,
     ) : ListElementViewData(

diff --git a/...ry/src/main/java/com/telefonica/mistica/sheet/children/list/adapter/ActionsListAdapter.kt b/...ry/src/main/java/com/telefonica/mistica/sheet/children/list/adapter/ActionsListAdapter.kt
@@ -26,6 +26,7 @@ internal class ActionsListAdapter(val items: List<RowActionViewData>) : Recycler
     override fun onBindViewHolder(holder: ActionsListViewHolder, position: Int) {
         val item = items[position]
         holder.text.text = item.title
+        holder.text.contentDescription = item.contentDescription
         if (item.asset != null) {
             holder.icon.loadRowAsset(item.asset)
             holder.icon.visibility = View.VISIBLE

diff --git a/library/src/main/java/com/telefonica/mistica/sheet/viewDataModelMappers.kt b/library/src/main/java/com/telefonica/mistica/sheet/viewDataModelMappers.kt
@@ -50,6 +50,7 @@ private fun RowAction.mapToViewData(childrenId: String, onBottomSheetClicked: In
             }
         },
         title = title,
+        contentDescription = contentDescription ?: title,
         asset = getRowAssetViewData(asset, rowAsset),
         rowActionStyle = when (style) {
             RowActionStyle.Default -> RowActionStyleViewData.Default

diff --git a/library/src/main/java/com/telefonica/mistica/util/AccesibilityElementType.kt b/library/src/main/java/com/telefonica/mistica/util/AccesibilityElementType.kt
@@ -0,0 +1,6 @@
+package com.telefonica.mistica.util
+
+enum class AccesibilityElementType {
+    Button,
+    Link,
+}