Remove unnecessary type assertions #7357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
force-pushed
the
remove-unnecessary-type-assertion
branch
from
a8d3b74 to
d702e29
Compare
pjonsson
commented
Jan 3, 2025
| @@ -145,7 +145,7 @@ class GeoJsonCatalogItem | |||
| // FeatureCollection to JsonValue | |||
| jsonData = mergeFeatureCollections( | |||
| featureCollections | |||
| ) as any as JsonValue; | |||
| ) as unknown as JsonValue; | |||
There was a problem hiding this comment.
Since this change removes most as any as, I changed the 3 remaining ones into as unknown as to fix some complaints from ESLint about using the any type.
pjonsson
force-pushed
the
remove-unnecessary-type-assertion
branch
from
d702e29 to
4c98869
Compare
pjonsson
force-pushed
the
remove-unnecessary-type-assertion
branch
from
4c98869 to
4e62128
Compare
These assertions do not change the type of the expression according to tsc, so remove the assertions. Fix is auto-generated by the typed ESLint typescript-eslint/no-unecessary-type-assertion rule.
pjonsson
force-pushed
the
remove-unnecessary-type-assertion
branch
from
4e62128 to
ed41f44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
These assertions do not change the type
of the expression according to tsc,
so remove the assertions.
Fix is auto-generated by the typed ESLint
typescript-eslint/no-unecessary-type-assertion
rule.
Test me
Run tsc on the sources/tested by CI.
Checklist
doc/.