Update to ESLint 9.20.1 #7437
Open
Update to ESLint 9.20.1 #7437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
commented
Jan 2, 2025
| "0", | ||
| "--report-unused-disable-directives" | ||
| ]); | ||
| runExternalModule(eslintExecutable, ["lib", "test", "--max-warnings", "0"]); |
There was a problem hiding this comment.
ESLint 9 complains about unused directives even without the parameter, so drop the parameter.
The globs in the config decide what files are matched, so I dropped the --ext parameter as well. If we add an ESLint plugin that lints scss files in the future, that should work without modifications of the gulpfile.
pjonsson
force-pushed
the
update-eslint
branch
from
8091514 to
eeeceff
Compare
pjonsson
force-pushed
the
update-eslint
branch
from
eeeceff to
8664b6a
Compare
pjonsson
commented
Feb 15, 2025
| "react/no-danger": "warn", | ||
| "react/no-did-update-set-state": "error", | ||
| "react/no-will-update-set-state": "error", | ||
| "react/prop-types": "error", |
There was a problem hiding this comment.
The react/prop-types was disabled in #7382 (comment), but apparently doesn't trigger 1400+ warnings in ESLint 9, so re-enable the rule.
Update to ESLint 9 since ESLint 8 reached end-of-life on 2024-10-05 and is no longer maintained. The main part of this PR is the new flat configuration file, which is quite close to a 1:1 migration of the previous non-flat config. The majority of lines is the rules section, which is the same as before except for the now deprecated rules that I removed.
pjonsson
force-pushed
the
update-eslint
branch
from
8664b6a to
e09f146
Compare
pjonsson
added a commit
to pjonsson/TerriaMap
that referenced
this pull request
Feb 19, 2025
Update to ESLint 9 since ESLint 8 reached end-of-life on 2024-10-05 and is no longer maintained. This is the TerriaMap part of TerriaJS/terriajs#7437
pjonsson
added a commit
to pjonsson/TerriaMap
that referenced
this pull request
Feb 20, 2025
Update to ESLint 9 since ESLint 8 reached end-of-life on 2024-10-05 and is no longer maintained. This is the TerriaMap part of TerriaJS/terriajs#7437
|
The corresponding TerriaMap PR is TerriaJS/TerriaMap#732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Depends on: #7411, #7382, #7381
Update to ESLint 9 since
ESLint 8 reached end-of-life
on 2024-10-05 and is no longer
maintained.
The main part of this PR is
the new flat configuration
file, which is quite close to
a 1:1 migration of the previous
non-flat config. The majority
of lines is the rules section,
which is the same as before
except for the now deprecated
rules that I removed.
Test me
Run
yarn gulp lint.Checklist
doc/.