-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI update #7443
base: main
Are you sure you want to change the base?
UI update #7443
Conversation
8fa34de
to
de1282d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Thanks for the review @zoran995 I've addressed most of these now except for 6), I'm in conversation with our designer about reverting to the small "Show workbench button" which would be my preference |
22d4930
to
d446557
Compare
Our client love the new changes! there is any ETA of them? |
b1c6ac3
to
a0071e8
Compare
Diff tool: keep side panel open, position accordingly remove patch files
- Remove use strict on .tsx files - fix keepCatalogOpen type
- run prettier
Fix location search result radius Revert changes to BottomLeftBar: attributions will be shown again
Update workbench comment Fix menu bar left margin when workbench closed Adjust toast position
8af19c0
to
8490771
Compare
Change trainer bar background color
18cd7c5
to
47ebc4c
Compare
c39d684
to
8c0126b
Compare
- adjust story panel width - reduce max height on story body -> 200px, remove padding when collapsed - prettier - lint fixes in workbench
8c0126b
to
d0aee46
Compare
Hi @irbian , we aim to get these changes released by the end of this month |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I performed another review of the code and UI, and everything seems fine.
It might be good to have someone else do one more quick review of the code, but it is your call, @ljowen. Maybe it is better to have this merged and further test it on the main before the release
What this PR does
Major change to default theme and appearance:
May introduce breaking changes with existing maps so will be a major version.
Visual changes
Before


After
Functional changes
keepCatalogOpen
Test me
Before: http://ci.terria.io/main
After: http://ci.terria.io/ui-update-fonts
Checklist
doc/
.