React imports 2 #7463
Open
React imports 2 #7463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
pjonsson
reviewed
Feb 13, 2025
zoran995
force-pushed
the
react-imports-2
branch
from
5791b0b to
f984210
Compare
|
I don't see any version updates in this PR, so I'm guessing a corresponding PR in the TerriaMap repository can be merged independently of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Supersedes the #7347, created new PR so build and deployment are available for testing
Small step toward #6538
Run upgrade-react-imports codemod to update react imports so they can work in react 17/18. Partially supersedes #7051.
Don't worry about merge conflicts first PR is only changes by codemod so it is easy to recreate
Test me
Tested locally
yarn gulp build. All tests passes. Running the app locally worksChecklist
doc/.