tsconfig: enable noUncheckedSideEffectImports #7464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes tsc error when doing a side effect import of a module that does not exist.
pjonsson
force-pushed
the
tsconfig-nouncheckedsideeffectimports
branch
from
81bd1a9 to
3bab44d
Compare
|
I had misunderstood how style-loader is invoked, so updated this PR to just enable the check in tsc and let #7471 handle the style-loader stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This makes tsc error when doing a side effect
import of a module that does not exist.
Test me
Change
import "inobounce";inStandardUserInterface.tsxtoimport "missing-inobounce";, then runyarn run tsc -band see that there is an error reported.Checklist
doc/.