Update to yarn v2 #7468
Open
Update to yarn v2 #7468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Github runner comes with yarn 1.22.22 preinstalled: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md
pjonsson
commented
Feb 16, 2025
| @@ -220,9 +220,8 @@ | |||
| "yaml": "^1.10.0" | |||
| }, | |||
| "scripts": { | |||
| "prepublish": "gulp post-npm-install", | |||
| "prepack": "gulp post-npm-install", | |||
There was a problem hiding this comment.
Renamed to prepack according to my understanding of the big warning box in the documentation: https://yarnpkg.com/advanced/lifecycle-scripts#prepublish
pjonsson
commented
Feb 16, 2025
| "postpublish": "bash -c \"if [ -z \"$GITHUB_ACTION\" ]; then git tag -a ${npm_package_version} -m \"${npm_package_version}\" && git push origin ${npm_package_version}; fi \"", | ||
| "postinstall": "gulp post-npm-install", |
There was a problem hiding this comment.
I think gulp post-npm-install is always run after building, so removed the hook since the warning box in the documentation is quite strongly worded against this hook: https://yarnpkg.com/advanced/lifecycle-scripts#postinstall
pjonsson
force-pushed
the
update-to-yarn-v2
branch
from
0308d97 to
1478cd9
Compare
This mirrors the TerriaMap PR: TerriaJS/TerriaMap#728 Fixes TerriaJS#6453
pjonsson
force-pushed
the
update-to-yarn-v2
branch
from
1478cd9 to
e2eec9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This mirrors the TerriaMap PR:
TerriaJS/TerriaMap#728
Fixes #6453
Test me
Not sure about the publish parts, I believe most other things are tested by CI.
Checklist
doc/.