tsify data catalog tab and convert it to functional component #7476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
reviewed
Feb 19, 2025
| placeholder={searchPlaceholder} | ||
| debounceDuration={ | ||
| terria.catalogReferencesLoaded && | ||
| searchState.catalogSearchProvider |
There was a problem hiding this comment.
This part of the condition is already checked on line 51.
pjonsson
reviewed
Feb 19, 2025
| interface DataCatalogTabProps { | ||
| items?: unknown[]; | ||
| searchPlaceholder?: string; | ||
| onActionButtonClicked?: () => void; |
There was a problem hiding this comment.
This type is (item: something) => void.
pjonsson
reviewed
Feb 19, 2025
|
|
||
| const changeSearchText = (newText: string) => { | ||
| runInAction(() => { | ||
| viewState.searchState.catalogSearchText = newText; |
There was a problem hiding this comment.
Should this use searchState.X instead of viewState.searchState.X just like the return statement a few lines below?
|
I did the straightforward (?) conversion to ES6 objects of some of this stuff in #7415, you might be able to cherry-pick the non-overlapping parts on top of this to get more TSification of this part of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is needed for mobx-react upgrade as part of an upgrade to react 18.
Test me
How should reviewers test this? (Hint: If you want to provide a test catalog item, create a Gist of its catalog JSON, add its url and your branch name to this url:
http://ci.terria.io/<branch name>/#clean&<raw url of your gist>, and then paste that in the body of this PR)Checklist
doc/.