-
-
Notifications
You must be signed in to change notification settings - Fork 46.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Monotonic Queue and sliding window maximum function with test cases #12226
Conversation
feat: implement Monotonic Queue and sliding window maximum function w…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
from collections import deque | ||
|
||
class MonotonicQueue: | ||
def __init__(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: __init__
. If the function does not return a value, please provide the type hint as: def function() -> None:
def __init__(self): | ||
self.deque = deque() | ||
|
||
def push(self, value): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file data_structures/queue/Monotonic_Queue.py
, please provide doctest for the function push
Please provide return type hint for the function: push
. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: value
self.deque.pop() | ||
self.deque.append(value) | ||
|
||
def max(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file data_structures/queue/Monotonic_Queue.py
, please provide doctest for the function max
Please provide return type hint for the function: max
. If the function does not return a value, please provide the type hint as: def function() -> None:
def max(self): | ||
return self.deque[0] | ||
|
||
def pop(self, value): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file data_structures/queue/Monotonic_Queue.py
, please provide doctest for the function pop
Please provide return type hint for the function: pop
. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: value
if self.deque and self.deque[0] == value: | ||
self.deque.popleft() | ||
|
||
def sliding_window_max(nums, k): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is no test file in this pull request nor any test function or class in the file data_structures/queue/Monotonic_Queue.py
, please provide doctest for the function sliding_window_max
Please provide return type hint for the function: sliding_window_max
. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: nums
Please provide descriptive name for the parameter: k
Please provide type hint for the parameter: k
for more information, see https://pre-commit.ci
Closing require_type_hints PRs to prepare for Hacktoberfest |
Describe your change:
Checklist: