CUT-4040: Limit Param for DI Functions #75
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
What does this solve?
The limit and skip params are being stripped in the DirectoryInsights module in favor of auto-pagination for results. With the reintroduction of the limit param, this will allow for manually setting limits which will save time in fetching results and will also allow for more precise filtering. If no limit param is specified, the function will automatically auto-paginate as it did previously
Is there anything particularly tricky?
NA
How should this be tested?
Get-JcSdkEvent -Service:('all') -StartTime:((Get-date).AddDays(-7)) -Limit 1 -Sort:("DESC")
(Get-JcSdkEvent -Service:('all') -StartTime:((Get-date).AddDays(-7)) -Sort:("DESC")).Count
Get-JcSdkEvent -Service:('all') -StartTime:((Get-date).AddDays(-30)) -Limit 1 -Sort:("DESC")
(Get-JcSdkEvent -Service:('all') -StartTime:((Get-date).AddDays(-7)) -Sort:("DESC")).Count
Screenshots