-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SA-3640-Get-JCassociation-Type-Bug-Fix #535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gweinjc
previously approved these changes
Oct 17, 2023
jworkmanjc
added
manual
manual module release (specify version in psd1)
and removed
patch
labels
Oct 18, 2023
jworkmanjc
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this, approved changes already for the proposed fix. Looks like our manual module release should work.
gweinjc
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested good for me
kmaranionjc
temporarily deployed
to
PublishToPSGallery
October 19, 2023 15:21 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
manual
manual module release (specify version in psd1)
PowerShell Module
Release for JumpCloud PowerShell Module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
What does this solve?
This change fixes issue where a device associated to a command gives error due to duplicate keys in the hash. Another issue is when a dynamic parameter -type is set, it does not get the right targetType.
Is there anything particularly tricky?
N/A
How should this be tested?
Get-JCAssociation -id YOURSYSTEM
and a system bound to a commandGet-JCAssociation -id YOURSYSTEM -type system
. Both commands should return an error