Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA-3640-Get-JCassociation-Type-Bug-Fix #535

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

kmaranionjc
Copy link
Contributor

Issues

  • SA-3640 - SA-3640-TargetTypeBugFix

What does this solve?

This change fixes issue where a device associated to a command gives error due to duplicate keys in the hash. Another issue is when a dynamic parameter -type is set, it does not get the right targetType.

Is there anything particularly tricky?

N/A

How should this be tested?

  1. First run these 2 commands before importing the fix module: Get-JCAssociation -id YOURSYSTEM and a system bound to a command Get-JCAssociation -id YOURSYSTEM -type system. Both commands should return an error
  2. Import-module
  3. Run same commands, validate the results should not have error

@kmaranionjc kmaranionjc added the PowerShell Module Release for JumpCloud PowerShell Module label Oct 17, 2023
@kmaranionjc kmaranionjc self-assigned this Oct 17, 2023
@kmaranionjc kmaranionjc requested a review from a team as a code owner October 17, 2023 14:21
@jworkmanjc
Copy link
Contributor

Thank you for the work on this!

Confirming the issue in 2.7.0:
Screenshot 2023-10-17 at 1 37 53 PM

And working now in this branch:
Screenshot 2023-10-17 at 1 40 59 PM

Screenshot 2023-10-17 at 1 41 09 PM

gweinjc
gweinjc previously approved these changes Oct 17, 2023
@jworkmanjc jworkmanjc added manual manual module release (specify version in psd1) and removed patch labels Oct 18, 2023
Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this, approved changes already for the proposed fix. Looks like our manual module release should work.

@gweinjc gweinjc self-requested a review October 18, 2023 22:16
Copy link
Contributor

@gweinjc gweinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested good for me

@kmaranionjc kmaranionjc merged commit d5035d1 into master Oct 19, 2023
7 checks passed
@kmaranionjc kmaranionjc temporarily deployed to PublishToPSGallery October 19, 2023 15:21 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manual manual module release (specify version in psd1) PowerShell Module Release for JumpCloud PowerShell Module
Development

Successfully merging this pull request may close these issues.

3 participants