Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sa 3608 build pack nuspec #536

Merged
merged 10 commits into from
Oct 18, 2023
Merged

Sa 3608 build pack nuspec #536

merged 10 commits into from
Oct 18, 2023

Conversation

jworkmanjc
Copy link
Contributor

@jworkmanjc jworkmanjc commented Oct 17, 2023

Issues

  • SA-3608 - nuspec/ nupkg updates for GitHub Actions

What does this solve?

Linux runners process the BuildNuspecForPsd1.ps1 file ever so slightly different from Windows or macOS systems. When building a nuspec file in linux, the nuspec file contains a flattened set of functions. In other words functions that are split between public and private directories were flattened into their sub directories like users and systems.

Some public functions reference these private functions by relative paths and when the nupkg file contains flattened function directories, those functions were inaccessible.

This release addresses the issue of building the nuspec file specifically for the ubuntu-latest runners in Github Actions. There is a new job introduced to the release step that will validate that the "Public" and "Private" directory exist within the nupkg file. The newly create nupkg file is uploaded as an artifact.

This step occurs before the manual approval job. SAs should be able to validate the nupkg file is correct before approving.

After manual approval, the nupkg artifact is downloaded, and published to PSGallery.

Is there anything particularly tricky?

How should this be tested?

I've built a new workflow to test this functionality, please reference the build-pack-pwsh-ci.yml file in this PR along with this run of GHA which shows the tests for the nupkg file, the artifact upload and download and adding the nuget sources before publish.

Screenshots

Screenshot 2023-10-17 at 12 54 36 PM

@jworkmanjc jworkmanjc requested a review from a team as a code owner October 17, 2023 18:49
gweinjc
gweinjc previously approved these changes Oct 17, 2023
Copy link
Contributor

@gweinjc gweinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

kmaranionjc
kmaranionjc previously approved these changes Oct 17, 2023
@jworkmanjc jworkmanjc dismissed stale reviews from kmaranionjc and gweinjc via c25e823 October 18, 2023 16:32
@gweinjc gweinjc self-requested a review October 18, 2023 16:40
@jworkmanjc jworkmanjc merged commit 366c18f into master Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants