-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut-4468-cascade-manager-remove-jc-user #631
Cut-4468-cascade-manager-remove-jc-user #631
Conversation
Update to windows uninstall script
Update to universal dmg to ensure current stable version is installed.
Update Mac - Install Chrome DMG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's chat about this as a team, I think there are a few changes that have to be made, there are a few changes that could be made to make this more readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need to change the branch to be merged into CUT-4394_JCDeviceFromCSV instead of master if we intend to release both features
Also when testing, there isn't any feedback whether or not the manager was actually cascaded or not, some kind of output might be beneficial to customers showcasing that the new manager assignment took place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few wording updates in the examples really, otherwise I think this is okay
PowerShell/JumpCloud Module/Tests/Public/Users/Remove-JCUser.Tests.ps1
Outdated
Show resolved
Hide resolved
Co-authored-by: Joe Workman <[email protected]>
Co-authored-by: Joe Workman <[email protected]>
Co-authored-by: Joe Workman <[email protected]>
…ests.ps1 Co-authored-by: Joe Workman <[email protected]>
Co-authored-by: Joe Workman <[email protected]>
Co-authored-by: Joe Workman <[email protected]>
Issues
What does this solve?
Adds functionality for cascading manager with Remove-JCUser
Is there anything particularly tricky?
n/a
How should this be tested?
Remove-JCUser -UserId id
Remove-JCUser -UserId id -force
Remove-JCUser -UserId id -force -CascadeManager user -CascadeManagerUser testUser
Remove-JCUser -UserId id -CascadeManager User -CascadeManagerUser Username/Id
Remove-JCUser -UserId id -CascadeManager auto
manager1
that is managed bymanager2
. This command should automatically cascade the manager of the managed users of manager1 to manager2 and remove/delete manager1Remove-JCUser -UserId id -CascadeManager null
Screenshots