support obico #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethjiang
commented
Feb 7, 2024
| //------------------------------------------ | ||
| namespace Slic3r { namespace GUI { | ||
|
|
||
| PrinterCloundAuthDialog::PrinterCloundAuthDialog(wxWindow* parent, PrintHost* host) |
There was a problem hiding this comment.
Change the name to CloudPrinterAuthDialog. Please don't misspell "Cloud".
src/slic3r/Utils/ObicoPrint.hpp
Outdated
|
|
||
| class DynamicPrintConfig; | ||
| class Http; | ||
| class ObicoPrint : public PrintHost |
There was a problem hiding this comment.
Change the name to be Obico
| @@ -415,6 +473,12 @@ void PhysicalPrinterDialog::update(bool printer_change) | |||
| if (wxTextCtrl* temp = dynamic_cast<wxTextCtrl*>(printhost_field->getWindow()); temp && temp->GetValue() == L"https://connect.prusa3d.com") { | |||
| temp->SetValue(wxString()); | |||
| } | |||
|
|
|||
| if (TextInput* temp_input = dynamic_cast<TextInput*>(printhost_field->getWindow()); temp_input) { | |||
There was a problem hiding this comment.
What's the purpose of this part? It looks quite hacky.
| @@ -436,6 +500,18 @@ void PhysicalPrinterDialog::update(bool printer_change) | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if (opt->value == htObico) { | |||
There was a problem hiding this comment.
This part is pretty hacky too.
| const PrinterTechnology tech = Preset::printer_technology(*m_config); | ||
| if (tech == ptFFF) { | ||
| const auto opt = m_config->option<ConfigOptionEnum<PrintHostType>>("host_type"); | ||
| if (opt->value == htObico) { |
There was a problem hiding this comment.
Can we move this part to Obico.cpp or CloudPrinterAuthDialog.cpp? We want to minimize the amount of code specific to Obico in the common classes
kennethjiang
added a commit
that referenced
this pull request
Jul 27, 2024
support obico (#3) Add printer support for Obico cloud. --------- Co-authored-by: zzh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.