Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename maximize param #1887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phedoreanu
Copy link

[ 72%] Building CXX object vncviewer/CMakeFiles/vncviewer.dir/DesktopWindow.cxx.o /Users/fedo/repos/tigervnc/vncviewer/DesktopWindow.cxx:177:7: error: reference to non-static member function must be called; did you mean to call it with no arguments?
177 | if (maximize) {
| ^~~~~~~~
| ()
/Users/fedo/repos/tigervnc/vncviewer/DesktopWindow.cxx:177:7: error: value of type 'void' is not contextually convertible to 'bool'
177 | if (maximize) {
| ^~~~~~~~
2 errors generated.
make[2]: *** [vncviewer/CMakeFiles/vncviewer.dir/DesktopWindow.cxx.o] Error 1
make[1]: *** [vncviewer/CMakeFiles/vncviewer.dir/all] Error 2
make: *** [all] Error 2

@phedoreanu phedoreanu force-pushed the bugfix/fix_macos_build branch 2 times, most recently from e66cfc7 to f6156a7 Compare December 16, 2024 12:12
@CendioOssman
Copy link
Member

This might be a feature at the moment, as it hinders people from building with the incompatible FLTK 1.4. :)

That said, rather than have a convoluted name, we can just refer to it with a global scope: ::maximize

@phedoreanu phedoreanu force-pushed the bugfix/fix_macos_build branch from f6156a7 to 9be0983 Compare December 16, 2024 19:42
@phedoreanu
Copy link
Author

Thanks! (I'm not a c++ dev 🙄 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants