Remove unnecessary mutexes #1891
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The decodered is already flagged as strictly ordered, which means it will only be used from a single thread at a time.
It uses the size_t type, which might not otherwise be defined.
A false return value from these methods result in an exception anyway, so let's keep things simple and throw the exception right away.
Reset individual contexts the same way we reset all contexts, i.e. by deleting and recreating them. Avoids surprises by having a consistent method.
Decoders are run in threads, and not everything in the logging system is thread safe. Normally decoders consider errors to be fatal and throw an exception. But the H.264 decoder wants to be able to tolerate misbehaving H.264 encoders.
This is not providing adequate protectection in more complex cases, and we're not making use of threads in a way that should require this. The exception is the WinVNC code, which is very thread heavy. But it is unmaintained and will not be a blocker for this.
This is not providing protection for all of the logging, so it gives a false sense of security. We're also not making use of this as we have barely any threading. The exception is the WinVNC code, which is very thread heavy. But it is unmaintained and will not be a blocker for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove many of the existing mutexes as they are either not needed, or provide incomplete protection and hence give a false sense of security.
We are currently only running viewer decoders on threads, so there is very little code that needs thread safety. And we can probably make do by writing that code in a way that doesn't access global objects¹.
The exception is the WinVNC code, which is very thread heavy. But it is unmaintained and will not be a blocker for this.
¹ I'd really like to enforce this, but I don't know how without sprinkling a thread id check in lots of places.