Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create TestUpload #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Create TestUpload #1

wants to merge 2 commits into from

Conversation

TimothySeah
Copy link
Owner

Test

TimothySeahTest
TimothySeahTest approved these changes Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@TimothySeahTest TimothySeahTest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the greatest PR of all time.

TimothySeahTest
TimothySeahTest requested changes Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@TimothySeahTest TimothySeahTest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to remove approval.

@TimothySeah TimothySeah removed the request for review from TimothySeahTest July 23, 2021 22:56
TimothySeahTest
TimothySeahTest reviewed Jul 24, 2021
View reviewed changes
Copy link
Collaborator

@TimothySeahTest TimothySeahTest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment (no changes needed).

TestUpload Show resolved Hide resolved
TimothySeahTest
TimothySeahTest requested changes Jul 24, 2021
View reviewed changes
TestUpload Show resolved Hide resolved
TimothySeahTest
TimothySeahTest requested changes Jul 24, 2021
View reviewed changes
Copy link
Collaborator

@TimothySeahTest TimothySeahTest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly make another request without any resolvable comments.

@TimothySeah
Copy link
Owner Author

Interesting that re-requesting did not remove me from attention set. Will this comment do the trick?

TimothySeahTest
TimothySeahTest approved these changes Jul 24, 2021
View reviewed changes
Copy link
Collaborator

@TimothySeahTest TimothySeahTest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now.

TimothySeahTest
TimothySeahTest reviewed Jul 24, 2021
View reviewed changes
Copy link
Collaborator

@TimothySeahTest TimothySeahTest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment without requesting changes.

@TimothySeah TimothySeah removed the request for review from TimothySeahTest July 24, 2021 01:51
TimothySeahTest
TimothySeahTest previously requested changes Jul 27, 2021
View reviewed changes
Copy link
Collaborator

@TimothySeahTest TimothySeahTest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i request changes

TimothySeahTest
TimothySeahTest requested changes Jul 27, 2021
View reviewed changes
Copy link
Collaborator

@TimothySeahTest TimothySeahTest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change.

@TimothySeah TimothySeah removed the request for review from TimothySeahTest July 27, 2021 02:39
TimothySeahTest
TimothySeahTest reviewed Jul 31, 2021
View reviewed changes
Copy link
Collaborator

@TimothySeahTest TimothySeahTest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment.

TimothySeahTest
TimothySeahTest reviewed Aug 2, 2021
View reviewed changes
Copy link
Collaborator

@TimothySeahTest TimothySeahTest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment without approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothySeahTest TimothySeahTest TimothySeahTest requested changes

Assignees

@TimothySeah TimothySeah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimothySeah @TimothySeahTest