Some simple improvements #80
Conversation
An entry that takes only numbers or calculations and calculates the result of the calculation
Change the default hover-cursor from hand1 to hand2
Change the movement cursor from exchange to fleur
Change the default cursor to use the native link pointer on Mac and Windows
Add __getitem__, __setitem__, config and configure, docstring formatting
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 89.51% 89.24% -0.27%
==========================================
Files 43 43
Lines 4026 4065 +39
==========================================
+ Hits 3604 3628 +24
- Misses 422 437 +15
Continue to review full report at Codecov.
|
Since Tk 8.6 supports png, I don't think it's actually necessary to use PIL. I hope no one uses Tk 8.5 these days. I know I forgot something very important but I can't remember what it is.
|
And while we are here, shouldn't we replace the uses of |
| assert frame.opened | ||
| frame.close() | ||
| self.window.update() | ||
| assert not frame.opened |
There was a problem hiding this comment.
There are good reasons to use assertTrue, assertFalse, assertEquals, and so on, so it's important that they are not changed. See also here.
There was a problem hiding this comment.
I use Pytest as test runner, which prefers the assert keyword, and logs usable output with it, but I see we're using Nose here, so I'll rewrite it.
| from ttkwidgets.utilities import get_assets_directory | ||
|
|
||
| assets_dir = Path(get_assets_directory()) |
There was a problem hiding this comment.
I like the use of pathlib, but why does it have to be a global variable?
There was a problem hiding this comment.
Well, I thought I might need it elsewhere, but it turns out I didn't.
No description provided.