Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop in transport #118

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fix infinite loop in transport #118

merged 1 commit into from
Dec 12, 2023

Conversation

MilesWilde
Copy link
Contributor

When using fairy ring teleports Transport would get infinite loops if it opened the fairy ring unexpectedly.

not sure why there are random line changes

thanks ClubXJ for the fix and bug report

@Torwent
Copy link
Owner

Torwent commented Dec 12, 2023

Thank you. Yeah infinite loops can be dangerous.

As for the random line changes, I think is because Simba is not always consistent with it's "new lines" and some times uses \r\n for a new line other times it uses just \n. Olly would probably know more about this, I'll ask him since this is definitely some kind of bug.
In any case, this also happens to me frequently

@Torwent Torwent merged commit dda6e8e into Torwent:master Dec 12, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants