Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1941] Evaluate value every time for count > 1 in sample-generator #7376

Merged
merged 2 commits into from
Jan 3, 2025
Merged

[NU-1941] Evaluate value every time for count > 1 in sample-generator #7376

merged 2 commits into from
Jan 3, 2025

Conversation

mslabek
Copy link
Member

@mslabek mslabek commented Dec 31, 2024

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Dec 31, 2024
@mslabek mslabek mentioned this pull request Dec 31, 2024
Merged
9 tasks
arkadius
arkadius reviewed Jan 2, 2025
View reviewed changes
docs/Changelog.md Outdated Show resolved Hide resolved
@mslabek mslabek force-pushed the nu-1941.evaluate-value-each-time-in-sample-generator branch from 05871a5 to f18fbd1 Compare January 2, 2025 14:49
@github-actions github-actions bot mentioned this pull request Jan 2, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

created: #7383
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

mslabek added 2 commits January 3, 2025 11:04
@mslabek
evaluate value every time for count > 1
503b519 
# Conflicts:
#	docs/Changelog.md
#	engine/flink/components/base-unbounded/src/main/scala/pl/touk/nussknacker/engine/flink/util/transformer/SampleGeneratorSourceFactory.scala
@mslabek
remove unused imports
0755a82
@mslabek mslabek force-pushed the nu-1941.evaluate-value-each-time-in-sample-generator branch from f18fbd1 to 0755a82 Compare January 3, 2025 10:05
@mslabek mslabek merged commit 8fdf5b6 into staging Jan 3, 2025
18 checks passed
@mslabek mslabek deleted the nu-1941.evaluate-value-each-time-in-sample-generator branch January 3, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mslabek @arkadius