Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom actions #7379

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Remove custom actions #7379

merged 2 commits into from
Jan 2, 2025

Conversation

mgoworko
Copy link
Contributor

@mgoworko mgoworko commented Dec 31, 2024

Describe your changes

Removed CustomAction mechanism. It was unused by Nussknacker (since making "run now" a normal, standard action, and not a custom action). Moreover, the CustomAction API was marked as experimental, and it was decided that it should be removed, because of maintenance effort required.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Jan 2, 2025
@TouK TouK deleted a comment from github-actions bot Jan 2, 2025
@mgoworko mgoworko marked this pull request as ready for review January 2, 2025 09:18
@mgoworko mgoworko merged commit ae4a37e into staging Jan 2, 2025
18 checks passed
@mgoworko mgoworko deleted the remove-custom-actions branch January 2, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe docs ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants