Significantly improve 1.15.5 create object parsing

TrinityCore · Feb 2, 2025 · 3046a31 · 3046a31
1 parent d34b15f
commit 3046a31
Show file tree

Hide file tree

Showing 6 changed files with 82 additions and 134 deletions.
diff --git a/WowPacketParser/Enums/Version/V1_15_5_57638/Opcodes.cs b/WowPacketParser/Enums/Version/V1_15_5_57638/Opcodes.cs
@@ -1952,7 +1952,7 @@ public static BiDictionary<Opcode, int> Opcodes(Direction direction)
             { Opcode.SMSG_SET_MAX_WEEKLY_QUANTITY, 0x370036 },
             { Opcode.SMSG_SET_MELEE_ANIM_KIT, 0x3701C8 },
             { Opcode.SMSG_SET_MOVEMENT_ANIM_KIT, 0x3701C7 },
-            { Opcode.SMSG_SET_PCT_SPELL_MODIFIER, 0x510028 },
+            // { Opcode.SMSG_SET_PCT_SPELL_MODIFIER, 0x510028 },
             { Opcode.SMSG_SET_PET_SPECIALIZATION, 0x3700BB },
             { Opcode.SMSG_SET_PLAYER_DECLINED_NAMES_RESULT, 0x4A000B },
             { Opcode.SMSG_SET_PLAY_HOVER_ANIM, 0x370052 },

diff --git a/WowPacketParserModule.Substructures/PerksProgramHandler.cs b/WowPacketParserModule.Substructures/PerksProgramHandler.cs
@@ -17,11 +17,11 @@ public static void ReadPerksVendorItem(Packet packet, params object[] indexes)
             packet.ReadInt32("TransmogIllusionID", indexes);
             packet.ReadInt32("ToyID", indexes);
             packet.ReadInt32("Price", indexes);
-            if (ClientVersion.AddedInVersion(ClientVersionBuild.V11_0_7_58123))
+            if (ClientVersion.AddedInVersion(ClientBranch.Retail, ClientVersionBuild.V11_0_7_58123))
                 packet.ReadInt32("OriginalPrice", indexes);
             packet.ReadTime64("AvailableUntil", indexes);
             packet.ReadBit("Disabled", indexes);
-            if (ClientVersion.AddedInVersion(ClientVersionBuild.V11_0_5_57171))
+            if (ClientVersion.AddedInVersion(ClientBranch.Retail, ClientVersionBuild.V11_0_5_57171))
                 packet.ReadBit("DoesNotExpire", indexes);
         }
     }