Skip to content

Commit

Permalink
Rename RafAcceptanceID to DynamicID in achievement packets
Browse files Browse the repository at this point in the history
  • Loading branch information
Shauren committed Jan 17, 2025
1 parent 66e6e15 commit 40d506d
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 28 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ public static void HandleCriteriaPlayer(Packet packet)
packet.ReadTime64("ElapsedTime");
packet.ReadTime64("CreationTime");

var hasRafAcceptanceID = packet.ReadBit("HasRafAcceptanceID");
var hasDynamicID = packet.ReadBit("HasDynamicID");

if (hasRafAcceptanceID)
packet.ReadUInt64("RafAcceptanceID");
if (hasDynamicID)
packet.ReadUInt64("DynamicID");

if (Settings.UseDBC)
if (DBC.Criteria.ContainsKey(criteriaId))
Expand All @@ -45,9 +45,9 @@ public static void ReadCriteriaProgress(Packet packet, params object[] indexes)

packet.ResetBitReader();

var hasRafAcceptanceID = packet.ReadBit("HasRafAcceptanceID", indexes);
if (hasRafAcceptanceID)
packet.ReadUInt64("RafAcceptanceID", indexes);
var hasDynamicID = packet.ReadBit("HasDynamicID", indexes);
if (hasDynamicID)
packet.ReadUInt64("DynamicID", indexes);

if (Settings.UseDBC)
if (DBC.Criteria.ContainsKey(criteriaId))
Expand Down
12 changes: 6 additions & 6 deletions WowPacketParserModule.V3_4_0_45166/Parsers/AchievementHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ public static void ReadCriteriaProgress(Packet packet, params object[] indexes)
packet.ReadTime64("CreationTime", indexes);

packet.ResetBitReader();
var hasRafAcceptanceID = packet.ReadBit("HasRafAcceptanceID", indexes);
if (hasRafAcceptanceID)
packet.ReadUInt64("RafAcceptanceID", indexes);
var hasDynamicID = packet.ReadBit("HasDynamicID", indexes);
if (hasDynamicID)
packet.ReadUInt64("DynamicID", indexes);

if (Settings.UseDBC)
if (DBC.Criteria.ContainsKey(criteriaId))
Expand Down Expand Up @@ -60,10 +60,10 @@ public static void HandleCriteriaPlayer(Packet packet)
packet.ReadTime64("ElapsedTime");
packet.ReadTime64("CreationTime");

var hasRafAcceptanceID = packet.ReadBit("HasRafAcceptanceID");
var hasDynamicID = packet.ReadBit("HasDynamicID");

if (hasRafAcceptanceID)
packet.ReadUInt64("RafAcceptanceID");
if (hasDynamicID)
packet.ReadUInt64("DynamicID");

if (Settings.UseDBC)
if (DBC.Criteria.ContainsKey(criteriaId))
Expand Down
12 changes: 6 additions & 6 deletions WowPacketParserModule.V4_4_0_54481/Parsers/AchievementHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ public static void ReadCriteriaProgress(Packet packet, params object[] indexes)

packet.ResetBitReader();

var hasRafAcceptanceID = packet.ReadBit("HasRafAcceptanceID", indexes);
if (hasRafAcceptanceID)
packet.ReadUInt64("RafAcceptanceID", indexes);
var hasDynamicID = packet.ReadBit("HasDynamicID", indexes);
if (hasDynamicID)
packet.ReadUInt64("DynamicID", indexes);

if (Settings.UseDBC)
if (DBC.Criteria.ContainsKey(criteriaId))
Expand Down Expand Up @@ -77,10 +77,10 @@ public static void HandleCriteriaPlayer(Packet packet)
packet.ReadTime64("ElapsedTime");
packet.ReadTime64("CreationTime");

var hasRafAcceptanceID = packet.ReadBit("HasRafAcceptanceID");
var hasDynamicID = packet.ReadBit("HasDynamicID");

if (hasRafAcceptanceID)
packet.ReadUInt64("RafAcceptanceID");
if (hasDynamicID)
packet.ReadUInt64("DynamicID");

if (Settings.UseDBC)
if (DBC.Criteria.ContainsKey(criteriaId))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ public static void HandleCriteriaPlayer(Packet packet)
packet.ReadTime("ElapsedTime");
packet.ReadTime("CreationTime");

var hasRafAcceptanceID = false;
var hasDynamicID = false;
if (ClientVersion.AddedInVersion(ClientVersionBuild.V8_2_5_31921))
hasRafAcceptanceID = packet.ReadBit();
hasDynamicID = packet.ReadBit();

if (hasRafAcceptanceID)
packet.ReadUInt64("RafAcceptanceID");
if (hasDynamicID)
packet.ReadUInt64("DynamicID");

if (Settings.UseDBC)
if (DBC.Criteria.ContainsKey(criteriaId))
Expand Down
12 changes: 6 additions & 6 deletions WowPacketParserModule.V9_0_1_36216/Parsers/AchievementHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ public static void HandleCriteriaPlayer(Packet packet)
packet.ReadTime("CreationTime");
}

var hasRafAcceptanceID = packet.ReadBit("HasRafAcceptanceID");
var hasDynamicID = packet.ReadBit("HasDynamicID");

if (hasRafAcceptanceID)
packet.ReadUInt64("RafAcceptanceID");
if (hasDynamicID)
packet.ReadUInt64("DynamicID");

if (Settings.UseDBC)
if (DBC.Criteria.ContainsKey(criteriaId))
Expand Down Expand Up @@ -60,9 +60,9 @@ public static void ReadCriteriaProgress(Packet packet, params object[] indexes)
packet.ResetBitReader();
packet.ReadBits("Flags", 4, indexes);

var hasRafAcceptanceID = packet.ReadBit("HasRafAcceptanceID", indexes);
if (hasRafAcceptanceID)
packet.ReadUInt64("RafAcceptanceID", indexes);
var hasDynamicID = packet.ReadBit("HasDynamicID", indexes);
if (hasDynamicID)
packet.ReadUInt64("DynamicID", indexes);

if (Settings.UseDBC)
if (DBC.Criteria.ContainsKey(criteriaId))
Expand Down

0 comments on commit 40d506d

Please sign in to comment.