Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add AutoDrive Simulator Dockerfile and Adds AutoDrive Devkit to robocar racestack's docker image #8

Merged
merged 12 commits into from
Oct 27, 2024

Conversation

chenyenru
Copy link

@chenyenru chenyenru commented Oct 9, 2024

Regarding Dockerfile:

Helpful when developing racestack with AutoDrive Simulator
@chenyenru chenyenru requested a review from WinstonHChou October 9, 2024 06:11

# Setup development environment
source /opt/ros/foxy/setup.bash
source /home/projects/f1tenth_ws/autodrive_devkit/install/setup.bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put autodrive_devkit/ under src/external/f1tenth_sim/autodrive_devkit/
It should not be tracked by git


# Copy and install AutoDRIVE Devkit (ROS 2 API)
RUN wget https://github.com/AutoDRIVE-Ecosystem/AutoDRIVE-F1TENTH-Sim-Racing/releases/download/2024-cdc/autodrive_devkit.zip && \
unzip autodrive_devkit.zip -d ${WORKSPACE}src/ && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put autodrive_devkit/ under src/external/f1tenth_sim/autodrive_devkit/
It should not be tracked by git

Copy link
Contributor

@WinstonHChou WinstonHChou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put autodrive_devkit/ under src/external/f1tenth_sim/autodrive_devkit/

@chenyenru chenyenru force-pushed the feature-autodrive-docker branch from 6376b36 to 0b52be7 Compare October 12, 2024 22:02
Introduces a new Dockerfile that combines the dependencies and configurations from both the f1tenth_x86 and AutoDrive Devkit Dockerfiles. The resulting Docker container will include all necessary dependencies to run the AutoDrive Devkit. Additionally, the AutoDrive Devkit repository will be cloned into the `src` directory within the container.

Source of AutoDrive Devkit: https://github.com/AutoDRIVE-Ecosystem/AutoDRIVE-F1TENTH-Sim-Racing/releases/tag/2024-cdc
@chenyenru chenyenru force-pushed the feature-autodrive-docker branch 2 times, most recently from 53aa134 to ffda584 Compare October 13, 2024 00:41
@chenyenru chenyenru force-pushed the feature-autodrive-docker branch from ffda584 to 29b3d8a Compare October 13, 2024 00:43
@WinstonHChou WinstonHChou self-requested a review October 16, 2024 04:56
@@ -0,0 +1,6 @@
repositories:
src/external/ackermann_odom:
Copy link
Contributor

@WinstonHChou WinstonHChou Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the directory to src/external/actuator/ackermann_odom
Please add annotation in https://github.com/chenyenru/ackermann-odom-ros2.git
If you used code from other organization

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting >>> ackermann_odom
--- stderr: ackermann_odom                           
CMake Error at CMakeLists.txt:17 (find_package):
  By not providing "Findbackward_ros.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "backward_ros", but CMake did not find one.

  Could not find a package configuration file provided by "backward_ros" with
  any of the following names:

    backward_rosConfig.cmake
    backward_ros-config.cmake

  Add the installation prefix of "backward_ros" to CMAKE_PREFIX_PATH or set
  "backward_ros_DIR" to a directory containing one of the above files.  If
  "backward_ros" provides a separate development package or SDK, be sure it
  has been installed.


---
Failed   <<< ackermann_odom [17.6s, exited with code 1]

Copy link
Contributor

@WinstonHChou WinstonHChou Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this dependency if you dont need it
I'd prefer not to install extra dependencies

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ERROR] [ackermann_odom_node-4]: exception occurred while executing process:
Traceback (most recent call last):
  File "/opt/ros/foxy/lib/python3.8/site-packages/launch/actions/execute_process.py", line 723, in __execute_process
    transport, self._subprocess_protocol = await async_execute_process(
  File "/opt/ros/foxy/lib/python3.8/site-packages/osrf_pycommon/process_utils/async_execute_process_asyncio/impl.py", line 142, in async_execute_process
    transport, protocol = yield from _async_execute_process_nopty(
  File "/opt/ros/foxy/lib/python3.8/site-packages/osrf_pycommon/process_utils/async_execute_process_asyncio/impl.py", line 46, in _async_execute_process_nopty
    transport, protocol = yield from loop.subprocess_exec(
  File "/usr/lib/python3.8/asyncio/base_events.py", line 1630, in subprocess_exec
    transport = await self._make_subprocess_transport(
  File "/usr/lib/python3.8/asyncio/unix_events.py", line 197, in _make_subprocess_transport
    transp = _UnixSubprocessTransport(self, protocol, args, shell,
  File "/usr/lib/python3.8/asyncio/base_subprocess.py", line 36, in __init__
    self._start(args=args, shell=shell, stdin=stdin, stdout=stdout,
  File "/usr/lib/python3.8/asyncio/unix_events.py", line 789, in _start
    self._proc = subprocess.Popen(
  File "/usr/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'gdb'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are missing map_path: "<map_path>" for yaml configuration

Copy link
Contributor

@WinstonHChou WinstonHChou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@WinstonHChou WinstonHChou merged commit 23a88f9 into foxy_devel Oct 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants