Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix adding swc configuration file support as an option #2143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hanseltime
Copy link

Summary

This PR implements what looks like the correct changes for ts-node to support specifying an swcConfig.

Unfortunately, the version of yarn has a bug that won't download the github based packages due to checksum mismatch and the tests seem very reliant on that particular yarn. If someone can point me to documentation for how to run the tests with out debugging tons of failures, I would be more than happy to implement additional tests.

This would unlock a lot of swc based flows as indicated in: #1856

@sdotson
Copy link

sdotson commented Dec 26, 2024

hi @hanseltime . excited to see you try to get this into ts-node. I'm not a maintainer or have any real power here, but happy to try to help. What errors are you seeing? I pulled down your pr and I only see one failing test transpilers › swc › verify that TS->SWC target mappings suppport all possible values from both TS and SWC.

To be fair, I see the same failure on main branch. Is this what you are seeing as well or are you referring to a different sort of error?

@hanseltime
Copy link
Author

hanseltime commented Dec 27, 2024

Hey @sdotson,

If you are capable of running the various tests, etc. Then that might help. The contributing.md doc seems to be out of date (or just doesn't handle me running this on a linux machine pop-os).

A list of the problems I have when trying to use the prescribed calls:

  1. yarn install fails because all of the "github" sourced packages fail checksums
  2. When I tell yarn to ignore checksums, then yarn build fails due to lots of strict failures:
src/test/repl/repl.spec.ts:574:23 - error TS7006: Parameter 't' implicitly has an 'any' type.

574   test('test', async (t) => {

As an example^

Running tests fails due to the same typescript build failures and it seems testing types aren't recognized. I could try getting something to work, but since I'm not sure if that would affect tests, I'm personally hamstrung to verify it.

For anyone who may be able to verify this, please feel free to do so!

@sdotson
Copy link

sdotson commented Jan 2, 2025

It sounds like something is going on with your local node or yarn installation. If you post whatever is logged to the conosle, I might be able to help. Google is telling me it might be worth checking your yarn/node version and perhaps running yarn cache clean.

As I noted in my previous message, it looks like tests still pass on my local machine! If you'd like to add an additional test, I can run and verify for you if needed.

@hanseltime
Copy link
Author

@sdotson - Something is definitely going on.

The yarn version is dictated by corepack from the project and I have verified that they match. Likewise with node. I have tried both 18 and 20 (18 is specified at places in the package.json). I may try getting to this to run on a different machine.

Since I am not finding any additional direction in the Contributing.md though, I'm not very willing to spend a lot of time debugging the build/test system without someone who understands the system providing any gotchas (i.e. maybe they've always used X setting to bypass this problem).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants