Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download all supported audio languages #556

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Download all supported audio languages #556

merged 4 commits into from
Dec 6, 2024

Conversation

Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Dec 6, 2024

Closes #549

@Tyrrrz Tyrrrz added the enhancement New feature or request label Dec 6, 2024
@Tyrrrz
Copy link
Owner Author

Tyrrrz commented Dec 6, 2024

If a video contains language-specific audio tracks, YoutubeDownloader will now include all of them in the output file, allowing the user to choose the audio track later during playback, similar to how subtitles are handled currently.

If a video does not contain language-specific audio tracks, the behavior will remain as before, downloading only the best available audio stream.

image

image

Audio-only downloads work as before, downloading only the best audio stream, preferably in the default language (if language-specific streams are available). This may change in the future, depending on user feedback.

@Tyrrrz Tyrrrz requested a review from Copilot December 6, 2024 19:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 suggestion.

Files not reviewed (3)
  • YoutubeDownloader.Core/YoutubeDownloader.Core.csproj: Language not supported
  • YoutubeDownloader/Views/Dialogs/SettingsView.axaml: Language not supported
  • YoutubeDownloader.Core/Downloading/VideoDownloader.cs: Evaluated as low risk

@Tyrrrz Tyrrrz merged commit e0d9524 into master Dec 6, 2024
17 checks passed
@Tyrrrz Tyrrrz deleted the multi-language branch December 6, 2024 19:47
@NEroousl
Copy link

That's GOOD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download a video in alternative languages
2 participants