EPIC: Multiple Values #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
daywiss
force-pushed
the
david/uma-2817-multiple-values-query-request-parsing
branch
from
7064f34 to
5830d23
Compare
Signed-off-by: david <[email protected]>
daywiss
force-pushed
the
david/uma-2817-multiple-values-query-request-parsing
branch
from
5830d23 to
1334d24
Compare
Signed-off-by: david <[email protected]>
src/helpers/converters.ts
Outdated
Comment on lines
42
to
44
| export const MIN_INT256 = -(BigInt(2) ** BigInt(255)); | ||
| export const MAX_INT256 = BigInt(2) ** BigInt(255) - BigInt(1); | ||
|
|
There was a problem hiding this comment.
These constants can be imported from viem, see here
gsteenkamp89
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
We want to add support for multiple_query identifier
changes
This parses the requests into a standard format for display in sidebar.
use this branch as the EPIC for this feature, dont merge