Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rails 8.0 #199

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Update to Rails 8.0 #199

merged 4 commits into from
Dec 23, 2024

Conversation

jxjj
Copy link
Contributor

@jxjj jxjj commented Dec 23, 2024

  • No major changes. A lot of code comments updated, which I accepted.
  • A couple gem notes:
    • twittter-bootstrap-rails abandoned. We've forked and updated to permit install on rails 8.
    • annotate abandoned. This is a dev gem to add annotations to models. I've left it as disabled, but we could move to annotaterb if we want.
    • exception_notification master branch was updated for 8.0, but they haven't released the gem yet, so moved gem source to the git repo.

On dev for testing

jxjj added 4 commits December 23, 2024 11:53
 running `bin/rails app:update`. Most things are minor config comment updates.
@jxjj jxjj requested a review from cmcfadden December 23, 2024 19:18
@jxjj jxjj self-assigned this Dec 23, 2024
Copy link
Member

@cmcfadden cmcfadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaa

@jxjj jxjj merged commit 6031e69 into develop Dec 23, 2024
2 checks passed
@jxjj jxjj mentioned this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants