Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RW-1109] Add generic query method to the completion plugin #95

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

orakili
Copy link
Contributor

@orakili orakili commented Nov 8, 2024

Refs: RW-1109

This adds a generic query method to the completion plugin to be able to use them outside of the chat (ex: https://github.com/UN-OCHA/ocha_content_classification).

This doesn't change the current functionality and is fully compatible with the chat.

@orakili orakili requested a review from attiks November 8, 2024 09:14
Copy link

Monitor coverage for Drupal 10.3.x - PHP 8.3

Totals Coverage
Statements: 87.88% ( 116 / 132 )
Methods: 25% ( 2 / 8 )
Lines: 91.94% ( 114 / 124 )

Copy link

Monitor coverage for Drupal 10.2.x - PHP 8.3

Totals Coverage
Statements: 87.88% ( 116 / 132 )
Methods: 25% ( 2 / 8 )
Lines: 91.94% ( 114 / 124 )

Copy link

Monitor coverage for Drupal 10.2.x - PHP 8.2

Totals Coverage
Statements: 87.88% ( 116 / 132 )
Methods: 25% ( 2 / 8 )
Lines: 91.94% ( 114 / 124 )

Copy link

Monitor coverage for Drupal 10.3.x - PHP 8.2

Totals Coverage
Statements: 87.88% ( 116 / 132 )
Methods: 25% ( 2 / 8 )
Lines: 91.94% ( 114 / 124 )

@orakili
Copy link
Contributor Author

orakili commented Nov 12, 2024

@attiks If you have the chance to review that so we can make a new release.

Copy link
Collaborator

@attiks attiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@orakili orakili merged commit 43635dd into develop Nov 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants