Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RWR 472 group version3 #848

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Conversation

lazysoundsystem
Copy link
Contributor

  • wip
  • more content to relationship name changes
  • update: move to group v3 and run database updates

Copy link

github-actions bot commented Nov 18, 2024

Build output

Composer Validate `success`

PHP Lint `success`

Docker Build `success`

Environment Setup `success`

Site Install `success`

PHP Code Sniffer `success`

Software Versions PHP 8.2.27 (cli) (built: Dec 19 2024 07:26:44) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.27, Copyright (c) Zend Technologies with Zend OPcache v8.2.27, Copyright (c), by Zend Technologies with Xdebug v3.4.0, Copyright (c) 2002-2024, by Derick Rethans Composer version 2.8.4 2024-12-11 11:57:47
Drupal Logs
PHP Logs

Pusher: @lazysoundsystem, Action: `pull_request`, Workflow: `Run tests``;

@lazysoundsystem
Copy link
Contributor Author

This wasn't so complicated in the end, but did require a lot of manual finding and replacing - https://www.drupal.org/docs/extending-drupal/contributed-modules/contributed-module-documentation/group/group-v2v3-guides/upgrading-from-v2-to-v3 - I think it's okay to include in this week's deployment, but I don't think there's any harm in waiting so we can test it better.
@attiks Do you have an opinion?

@attiks
Copy link
Contributor

attiks commented Nov 18, 2024

Best to let them test as well, like creating operations, clusters, adding members, ...

@lazysoundsystem
Copy link
Contributor Author

Okay, putting the 'blocked' label till we've tested further.

@lazysoundsystem lazysoundsystem added the blocked Do not merge this label Nov 18, 2024
@lazysoundsystem
Copy link
Contributor Author

@attiks thanks for having a look - I tried deploying this to the stage instance, but hitting familiar errors for each of the base_field_override config files:

https://jenkins.aws.ahconu.org/view/Response/job/response-stage-deploy/90/console

16:33:46  >   The import failed due to the following reasons:                              
16:33:46  >   Unexpected error during import with operation delete for core.base_field_ov  
16:33:46  >   erride.group_content.cluster-group_membership.path: The "group_content  
16:33:46  >   " entity type does not exist.   
etc

@attiks
Copy link
Contributor

attiks commented Jan 9, 2025

Fixed by a second deploy

Copy link

Coverage Report

Totals Coverage
Statements: 43.18% ( 1592 / 3687 )
Methods: 25.53% ( 24 / 94 )
Lines: 43.64% ( 1568 / 3593 )

@lazysoundsystem lazysoundsystem removed the blocked Do not merge this label Feb 4, 2025
@lazysoundsystem
Copy link
Contributor Author

This has been tested and is ready for merging.

I'm still a bit nervous about the double deploy, but I've tried it a few times and it works consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants